Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23 and #26
This PR improves webgl performance by reducing the number of gl calls. For more information click here
===
to avoid reuploading common scene parameters like camera matrix or lightsMost of this was done together with @ianmackenzie. He also set up a test scene using the soon-to-be-released elm-3d-scene package, that we used to benchmark the performance:
@MartinSStewart, who had opened the original issue, provided the source code of his game. Here you can see that it got slightly better:
Here you can see the absence of redundant calls:
There were a lot of bugs, because of the stateful nature of webgl. In order to ensure that it works, I tested it using the following projects: