-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to create stable/dev/edge docker builds using git tags and GH actions + enable docker build cache #61
Conversation
* testing if gha cache is used https://docs.docker.com/engine/reference/commandline/buildx_build/#cache-from https://docs.docker.com/engine/reference/commandline/buildx_build/#cache-to * try out inline cache src: https://github.com/moby/buildkit#export-cache * go back to using gha cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you very much!
very nice |
I am glad! |
Hi @RoguedBear , I noticed that it does not matter which choice I make, it always pushes with the tag "main". I assume it is using the branch name, since none of the options is "main". |
Hi @ellite , Yes you are correct that it is using the branch name Having the branch name also as an option to push as a image tag leaves you open to the option of having branch specific images, if in future you decide to have a I hope this clarifies. Please let me know if you have further queries |
Sorry. I am bit lost. What do slecting |
As the discussion was going on in here #51 (comment), the idea was that wallos could make versioned releases. following a version scheme like semver to indicate if the type of change is a bugfix/new feature/breaking changes, since having everything on the latest wouldnt give someone the ability to rollback if need be. To do that whenever you would create a new github release (and hence a new version tag), you can select that tag through the run options, and As for the The comments in that issue reiterate what i am saying in more descriptive ways. I hope this clarifies. feel free to ask again if something is unclear. Also if you want to experiment around with creating tags and using the workflow, i can add you as a collaborator to my fork (which hopefully should allow you to run github actions on my repo and create new tags) |
as discussed in #51, i have added the option to mark the image being built for a git tag as
dev
/edge
/stable
(stable also beinglatest
).This is how the workflow dispatch menu would look like:
And all the tags published are here: https://hub.docker.com/r/roguedbear/wallos-test/tags?page=1&ordering=last_updated
For the branch input:
latest
tag is only published whenstable
build type is selectedAlso, optionally i noticed that image build time was around 15minutes, and image was being built entirely everytime, so I have enabled build cache too. So hopefully once an image is built, on future builds, caches for unchanged layers should not get invalidated resulting in faster build time.
https://github.com/RoguedBear/Wallos/actions/workflows/build-images.yml
Please let me know if you have additional feedbacks or want something changed.
closes #51