Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NoDebugAttr #827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cornelk
Copy link

@cornelk cornelk commented Jan 19, 2020

Fixes panic: unknown node type: 'NoDebugAttr 0x2ebd788 <col:59>'


This change is Reviewable

Copy link
Owner

@elliotchance elliotchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Owner

@elliotchance elliotchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine, but there are build failures unrelated to the change because it looks like travis has changed their underlying image. As to not break dev, I will put in a PR to update the build first.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@elliotchance
Copy link
Owner

I have tried to update go and clang. However, there are a few years of upgrades and the changes are not trivial: #828

The next few months will be too busy for me to visit this project in any more depth. You are welcome to try and get the build working with my changes and I will happily review and merge it.

Unfortunately this means this PR will remain stalled until then.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@4de3ec9). Click here to learn what that means.
Patch coverage: 52.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #827   +/-   ##
=========================================
  Coverage          ?   77.86%           
=========================================
  Files             ?      170           
  Lines             ?     9814           
  Branches          ?        0           
=========================================
  Hits              ?     7642           
  Misses            ?     1695           
  Partials          ?      477           
Impacted Files Coverage Δ
ast/position.go 76.82% <0.00%> (ø)
ast/no_debug_attr.go 52.94% <52.94%> (ø)
ast/ast.go 98.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants