Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fileCache on Windows. Fixes #775 #776

Merged

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Jun 26, 2018

Backslashes needed to be unescaped, otherwise the file would not be found in the cache later on.

Fixes #775


This change is Reviewable

Backslashes need to be unescaped
@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #776 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files         169      169           
  Lines        9781     9781           
=======================================
  Hits         7843     7843           
  Misses       1489     1489           
  Partials      449      449
Impacted Files Coverage Δ
cc/preprocessor.go 93.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed4e69...7a89481. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@elliotchance elliotchance merged commit dc4b557 into elliotchance:master Jun 27, 2018
@kamphaus kamphaus deleted the fix-775-windows-character-literal branch June 27, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants