Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AST node type NoAliasAttr. Fixes #769 #770

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Jun 21, 2018

Fixes #769


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #770 into master will decrease coverage by 0.06%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   80.69%   80.63%   -0.07%     
==========================================
  Files         166      167       +1     
  Lines        9485     9506      +21     
==========================================
+ Hits         7654     7665      +11     
- Misses       1398     1408      +10     
  Partials      433      433
Impacted Files Coverage Δ
ast/position.go 79.09% <0%> (-0.52%) ⬇️
ast/ast.go 98.31% <100%> (+0.01%) ⬆️
ast/no_alias_attr.go 52.94% <52.94%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3609ec...a30c3fe. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 4 of 4 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@elliotchance elliotchance merged commit 525340c into elliotchance:master Jun 21, 2018
@kamphaus kamphaus deleted the fix-769-ast-no-alias-attr branch June 22, 2018 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants