Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify to use go v1.9.x for Travis CI. Fixes #752 #753

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Jun 17, 2018

Fixes #752


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9cd4973). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #753   +/-   ##
=========================================
  Coverage          ?   80.79%           
=========================================
  Files             ?      166           
  Lines             ?     9478           
  Branches          ?        0           
=========================================
  Hits              ?     7658           
  Misses            ?     1388           
  Partials          ?      432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd4973...3e2cfab. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


.travis.yml, line 4 at r1 (raw file):

go:
  - "1.9.x"

Wow, I can't believe I never actually specified a Go version in CI... that's my bad :|


Comments from Reviewable

@elliotchance elliotchance merged commit 14bb3e8 into elliotchance:master Jun 17, 2018
@kamphaus kamphaus deleted the fix-752-travis-ci branch June 18, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants