Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function definition by C include header list. Fixes #237 #627

Merged
merged 3 commits into from Feb 14, 2018
Merged

Function definition by C include header list. Fixes #237 #627

merged 3 commits into from Feb 14, 2018

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Feb 12, 2018

Close #237


This change is Reviewable

@Konstantin8105 Konstantin8105 changed the title Function definition by C include headers .Fix #237 Function definition by C include headers. Fix #237 Feb 12, 2018
@Konstantin8105 Konstantin8105 changed the title Function definition by C include headers. Fix #237 Function definition by C include header list. Fix #237 Feb 12, 2018
@codecov
Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #627 into master will increase coverage by 0.2%.
The diff coverage is 96.03%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #627     +/-   ##
=========================================
+ Coverage   80.28%   80.49%   +0.2%     
=========================================
  Files         158      158             
  Lines        8178     8202     +24     
=========================================
+ Hits         6566     6602     +36     
+ Misses       1241     1229     -12     
  Partials      371      371
Impacted Files Coverage Δ
program/program.go 87.93% <100%> (+0.32%) ⬆️
main.go 55.88% <100%> (+0.65%) ⬆️
transpiler/call.go 69.46% <100%> (+1.32%) ⬆️
program/function_definition.go 100% <100%> (ø) ⬆️
transpiler/functions.go 90.35% <100%> (ø) ⬆️
preprocessor/preprocessor.go 82.12% <87.09%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05551f0...6f75731. Read the comment docs.

@elliotchance elliotchance changed the title Function definition by C include header list. Fix #237 Function definition by C include header list. Fixes #237 Feb 13, 2018
@elliotchance
Copy link
Owner

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance
Copy link
Owner

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


a discussion (no related file):
This is fine, I just can't merge until the conflicts are resolved.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 1cedcd0 into elliotchance:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants