Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malloc implementation for VarDecl. Fix #515 #535

Merged
merged 11 commits into from Jan 10, 2018
Merged

malloc implementation for VarDecl. Fix #515 #535

merged 11 commits into from Jan 10, 2018

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Jan 5, 2018

Close #515
Need for #67


This change is Reviewable

@Konstantin8105 Konstantin8105 mentioned this pull request Jan 5, 2018
9 tasks
@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #535 into master will decrease coverage by 0.01%.
The diff coverage is 77.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   80.65%   80.64%   -0.02%     
==========================================
  Files         148      148              
  Lines        7187     7214      +27     
==========================================
+ Hits         5797     5818      +21     
- Misses       1062     1066       +4     
- Partials      328      330       +2
Impacted Files Coverage Δ
transpiler/variables.go 80.73% <75%> (-0.34%) ⬇️
transpiler/binary.go 63.76% <78.26%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886c985...9350d8f. Read the comment docs.

@Konstantin8105 Konstantin8105 changed the title malloc implementation for VarDecl malloc implementation for VarDecl. Fix #515 Jan 5, 2018
@elliotchance
Copy link
Owner

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


transpiler/binary.go, line 376 at r1 (raw file):

	var expr *ast.CallExpr

	foundCall = func(n ast.Node) {

Please avoid anonymous functions. Move it to a private function outside.


Comments from Reviewable

@elliotchance
Copy link
Owner

Review status: all files reviewed at latest revision, 2 unresolved discussions.


transpiler/binary.go, line 418 at r1 (raw file):

}

func GenerateAlloc(p *program.Program, allocSize ast.Node, leftType string) (

Does this need to be in the public API? Otherwise use generateAlloc.


Comments from Reviewable

@Konstantin8105
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 2 unresolved discussions.


transpiler/binary.go, line 376 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

Please avoid anonymous functions. Move it to a private function outside.

Done.


transpiler/binary.go, line 418 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

Does this need to be in the public API? Otherwise use generateAlloc.

Done.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 05c9784 into elliotchance:master Jan 10, 2018
@Konstantin8105 Konstantin8105 deleted the mallocIssue67 branch January 16, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants