-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
malloc implementation for VarDecl. Fix #515 #535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 80.65% 80.64% -0.02%
==========================================
Files 148 148
Lines 7187 7214 +27
==========================================
+ Hits 5797 5818 +21
- Misses 1062 1066 +4
- Partials 328 330 +2
Continue to review full report at Codecov.
|
Reviewed 3 of 3 files at r1. transpiler/binary.go, line 376 at r1 (raw file):
Please avoid anonymous functions. Move it to a private function outside. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. transpiler/binary.go, line 418 at r1 (raw file):
Does this need to be in the public API? Otherwise use Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. transpiler/binary.go, line 376 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. transpiler/binary.go, line 418 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Close #515
Need for #67
This change is