Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typedef for union. Fixes #475, #496, #508, #522, #524 and #556 #523

Merged
merged 19 commits into from Jan 14, 2018
Merged

Typedef for union. Fixes #475, #496, #508, #522, #524 and #556 #523

merged 19 commits into from Jan 14, 2018

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Jan 3, 2018

Close #475
Close #524
Close #522
Close #508
Close #496
Close #556


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #523 into master will decrease coverage by 0.42%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   80.46%   80.04%   -0.43%     
==========================================
  Files         156      156              
  Lines        7460     7373      -87     
==========================================
- Hits         6003     5902     -101     
- Misses       1126     1135       +9     
- Partials      331      336       +5
Impacted Files Coverage Δ
transpiler/variables.go 80.9% <100%> (+0.17%) ⬆️
transpiler/call.go 68.15% <100%> (+0.31%) ⬆️
transpiler/enum.go 91.28% <100%> (+0.18%) ⬆️
util/goast.go 88.23% <100%> (-2.05%) ⬇️
transpiler/translation_unit.go 81.48% <100%> (+1.48%) ⬆️
transpiler/declarations.go 82.26% <69.23%> (-1.21%) ⬇️
transpiler/unary.go 74.32% <75%> (+0.1%) ⬆️
transpiler/binary.go 66.07% <85.71%> (+2.3%) ⬆️
transpiler/union.go 91.17% <90%> (-8.83%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c0eba...af21eb7. Read the comment docs.

@Konstantin8105
Copy link
Contributor Author

For success of that PR need #525

@Konstantin8105
Copy link
Contributor Author

Not ready for review

@elliotchance
Copy link
Owner

Reviewed 6 of 6 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@elliotchance elliotchance changed the title Typedef for union Typedef for union. Fixes #475, #522 and #524 Jan 3, 2018
@Konstantin8105
Copy link
Contributor Author

Ready for review, if by travis is Ok.

@elliotchance elliotchance changed the title Typedef for union. Fixes #475, #522 and #524 Typedef for union. Fixes #475, #496, #508, #522 and #524 Jan 4, 2018
@Konstantin8105
Copy link
Contributor Author

ready for review.

@elliotchance
Copy link
Owner

Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


transpiler/binary.go, line 297 at r3 (raw file):

			var findUnion func(ast.Node)
			var UnionNode ast.Node
			findUnion = func(node ast.Node) {

Please avoid anonymous functions.


Comments from Reviewable

@Konstantin8105
Copy link
Contributor Author

Review status: 8 of 10 files reviewed at latest revision, 1 unresolved discussion.


transpiler/binary.go, line 297 at r3 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

Please avoid anonymous functions.

Done


Comments from Reviewable

@Konstantin8105
Copy link
Contributor Author

Ready for review.

@Konstantin8105 Konstantin8105 changed the title Typedef for union. Fixes #475, #496, #508, #522 and #524 Typedef for union. Fixes #475, #496, #508, #522, #524 and #556 Jan 13, 2018
@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r4, 6 of 6 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 7b46c33 into elliotchance:master Jan 14, 2018
@Konstantin8105 Konstantin8105 deleted the UnionInStruct2 branch January 16, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants