-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typedef for union. Fixes #475, #496, #508, #522, #524 and #556 #523
Conversation
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
- Coverage 80.46% 80.04% -0.43%
==========================================
Files 156 156
Lines 7460 7373 -87
==========================================
- Hits 6003 5902 -101
- Misses 1126 1135 +9
- Partials 331 336 +5
Continue to review full report at Codecov.
|
For success of that PR need #525 |
Not ready for review |
Reviewed 6 of 6 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Ready for review, if by travis is Ok. |
ready for review. |
Reviewed 6 of 6 files at r3. transpiler/binary.go, line 297 at r3 (raw file):
Please avoid anonymous functions. Comments from Reviewable |
Review status: 8 of 10 files reviewed at latest revision, 1 unresolved discussion. transpiler/binary.go, line 297 at r3 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done Comments from Reviewable |
Ready for review. |
Reviewed 2 of 2 files at r4, 6 of 6 files at r5. Comments from Reviewable |
Close #475
Close #524
Close #522
Close #508
Close #496
Close #556
This change is