-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go format checking on travis #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 73.59% 73.59%
=======================================
Files 66 66
Lines 1530 1530
=======================================
Hits 1126 1126
Misses 378 378
Partials 26 26 Continue to review full report at Codecov.
|
This will be a fix for #40 (Add "go fmt" to travis). |
Reviewed 2 of 2 files at r1. Comments from Reviewable |
Awesome, thanks @pravj ! |
apologies for coming late to the party. instead of adding this to Travis-CI, I prefer to create a see: |
@sbinet - I like that ides. One thing that is bugging me is we are mixing integration and unit tests with |
a "simple" workaround is to prefix all unit tests with ie: |
The standard library makes unit tests use short mode, so to run all unit tests use |
This pull request add a source code format checking using
gofmt
.It customises the build's
script
section and does a format check before running the test cases.If the source code is not formatted according to the standard, it will fail the build suggesting the prospective changes.
This change is