Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error context to dereferenced type. Fixes #491 #492

Merged
merged 1 commit into from Dec 20, 2017
Merged

Add error context to dereferenced type. Fixes #491 #492

merged 1 commit into from Dec 20, 2017

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Dec 20, 2017

Close #491


This change is Reviewable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

Merging #492 into master will decrease coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #492      +/-   ##
=========================================
- Coverage   79.96%   79.9%   -0.06%     
=========================================
  Files         146     146              
  Lines        6837    6842       +5     
=========================================
  Hits         5467    5467              
- Misses       1065    1069       +4     
- Partials      305     306       +1
Impacted Files Coverage Δ
transpiler/binary.go 60% <0%> (-1.15%) ⬇️
types/dereference.go 81.25% <66.66%> (-18.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aba2df...3cae49a. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance elliotchance changed the title add error context Add error context to dereferenced type. Fixes #491 Dec 20, 2017
@elliotchance elliotchance merged commit eac4b15 into elliotchance:master Dec 20, 2017
@Konstantin8105 Konstantin8105 deleted the ContextForError branch December 26, 2017 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants