Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for function pointers. Fixes #85 and #157 #469

Merged
merged 41 commits into from Dec 18, 2017
Merged

Add support for function pointers. Fixes #85 and #157 #469

merged 41 commits into from Dec 18, 2017

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Dec 14, 2017

Not ready for review


This change is Reviewable

@elliotchance
Copy link
Owner

I will wait until you say its ready for review 😄


Review status: 0 of 14 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@codecov
Copy link

codecov bot commented Dec 15, 2017

Codecov Report

Merging #469 into master will decrease coverage by 1.02%.
The diff coverage is 69.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   80.97%   79.95%   -1.03%     
==========================================
  Files         145      145              
  Lines        6565     6719     +154     
==========================================
+ Hits         5316     5372      +56     
- Misses        980     1048      +68     
- Partials      269      299      +30
Impacted Files Coverage Δ
ast/implicit_cast_expr.go 91.3% <ø> (ø) ⬆️
program/program.go 82.92% <100%> (+2.64%) ⬆️
transpiler/translation_unit.go 73.68% <100%> (+0.71%) ⬆️
ast/array_subscript_expr.go 90.47% <100%> (+1%) ⬆️
types/resolve.go 75.57% <100%> (+0.94%) ⬆️
types/sizeof.go 90.69% <100%> (+0.22%) ⬆️
transpiler/binary.go 61.14% <47.05%> (-2.93%) ⬇️
transpiler/variables.go 80.35% <50%> (-1.58%) ⬇️
transpiler/branch.go 75.12% <50%> (-0.78%) ⬇️
transpiler/declarations.go 82.67% <60%> (-1.47%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d0713...7b4a624. Read the comment docs.

@Konstantin8105 Konstantin8105 changed the title Functoin pointer Function pointer Dec 15, 2017
@Konstantin8105
Copy link
Contributor Author

Not ready in according to travis

@Konstantin8105
Copy link
Contributor Author

Konstantin8105 commented Dec 18, 2017

Removed list #85

@Konstantin8105
Copy link
Contributor Author

Ready for review

@Konstantin8105 Konstantin8105 mentioned this pull request Dec 18, 2017
9 tasks
@Konstantin8105 Konstantin8105 mentioned this pull request Dec 18, 2017
13 tasks
@Konstantin8105
Copy link
Contributor Author

If you want, then I can try to separate to small PRs.

@elliotchance
Copy link
Owner

This is a such a big and great feature it will be the v0.19.0 Uranium release 👍

@elliotchance
Copy link
Owner

Reviewed 11 of 16 files at r1, 6 of 7 files at r2, 3 of 4 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance elliotchance changed the title Function pointer Add support for function pointers. Fixes #85 and #157 Dec 18, 2017
@elliotchance elliotchance merged commit 1116413 into elliotchance:master Dec 18, 2017
@Konstantin8105 Konstantin8105 deleted the functoinPointer3 branch December 26, 2017 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants