Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting ImplicitValueInitExpr. Fixes #424 #454

Merged
merged 4 commits into from Dec 13, 2017
Merged

Supporting ImplicitValueInitExpr. Fixes #424 #454

merged 4 commits into from Dec 13, 2017

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Dec 12, 2017

Close #424
See #67


This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #454 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage    81.1%   81.09%   -0.02%     
==========================================
  Files         145      145              
  Lines        6511     6527      +16     
==========================================
+ Hits         5281     5293      +12     
- Misses        968      970       +2     
- Partials      262      264       +2
Impacted Files Coverage Δ
transpiler/transpiler.go 82.9% <75%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fdac7...1af9581. Read the comment docs.

@elliotchance elliotchance changed the title supporting ImplicitValueInitExpr Supporting ImplicitValueInitExpr. Fixes #424 Dec 13, 2017
@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit e7e65f5 into elliotchance:master Dec 13, 2017
@Konstantin8105 Konstantin8105 deleted the ImplicitValueInitExpr branch December 26, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants