Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

while without body. Fixes #444 #447

Merged
merged 1 commit into from Dec 11, 2017
Merged

while without body. Fixes #444 #447

merged 1 commit into from Dec 11, 2017

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Dec 11, 2017

Close #444
See #67


This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 11, 2017

Codecov Report

Merging #447 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   81.03%   81.04%   +<.01%     
==========================================
  Files         145      145              
  Lines        6434     6436       +2     
==========================================
+ Hits         5214     5216       +2     
  Misses        962      962              
  Partials      258      258
Impacted Files Coverage Δ
transpiler/branch.go 75.89% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b1249...0c2e9e9. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance changed the title while without body while without body. Fixes #444 Dec 11, 2017
@elliotchance elliotchance merged commit b9dc968 into elliotchance:master Dec 11, 2017
@Konstantin8105 Konstantin8105 deleted the withWithouBody branch December 26, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants