Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with preprocessor including the same file multiple times. Fixes 363 #369

Merged
merged 5 commits into from Nov 28, 2017

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Nov 25, 2017

See #363


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 25, 2017

Codecov Report

Merging #369 into master will increase coverage by 0.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   81.71%   81.73%   +0.01%     
==========================================
  Files         144      144              
  Lines        6192     6208      +16     
==========================================
+ Hits         5060     5074      +14     
- Misses        907      908       +1     
- Partials      225      226       +1
Impacted Files Coverage Δ
preprocessor/preprocessor.go 70.7% <89.47%> (+3.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa8212...cfc3c7f. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


preprocessor/preprocessor.go, line 41 at r2 (raw file):

				allItems[i].other == allItems[j].other &&
				len(allItems[i].lines) == len(allItems[j].lines) {
				indentical := true

"identical". Can you also explain a bit what this code is doing with a comment?


Comments from Reviewable

@Konstantin8105
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


preprocessor/preprocessor.go, line 41 at r2 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

"identical". Can you also explain a bit what this code is doing with a comment?

Yes, you are right . This part of code, is huge. So I separate to function isSame.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance changed the title fix 363 Fixed bug with preprocessor including the same file multiple times. Fixes 363 Nov 28, 2017
@elliotchance elliotchance merged commit dca511c into elliotchance:master Nov 28, 2017
@Konstantin8105 Konstantin8105 deleted the defineProblem branch December 12, 2017 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants