-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typedef inside function. Fixes #272 #347
Conversation
@elliotchance I am still trying to come up with tests for this change, but all the tests require #322 to be fixed first. It is up to you to decide if you want to wait for #322. |
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 81.62% 81.62% +<.01%
==========================================
Files 142 142
Lines 6013 6014 +1
==========================================
+ Hits 4908 4909 +1
Misses 885 885
Partials 220 220
Continue to review full report at Codecov.
|
Could you check the result of that example: int main(){
typedef int INT;
INT i = 42;
return 0;
} Is look like that : type INT int // <---- Outside of function
func main(){
var i INT = 42;
} |
@Konstantin8105 Hi. This is an easy fix that will fix most of the typedef cases. I opened another issue #346 to fix the rare cases (?) where a typedef is defined multiple times (with different target types) within the same compilation unit. |
@yulvil Hello, yes you are right. Now, |
I don't see any test cases for this so I'm not sure what has changed? Reviewed 1 of 1 files at r1. Comments from Reviewable |
@elliotchance I need to fix #322 before I can write a test case that is working. |
Do you want it merged or do you want me to wait for #322? Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
@elliotchance Please merge. I think it is safe. I will provide tests later. |
For #272
This change is