Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sizeof(char *const [5]). Fixes #286 #310

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Fixed sizeof(char *const [5]). Fixes #286 #310

merged 2 commits into from
Nov 2, 2017

Conversation

yulvil
Copy link
Contributor

@yulvil yulvil commented Nov 2, 2017

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #310 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   81.85%   81.86%   +<.01%     
==========================================
  Files         136      136              
  Lines        5588     5591       +3     
==========================================
+ Hits         4574     4577       +3     
  Misses        815      815              
  Partials      199      199
Impacted Files Coverage Δ
types/sizeof.go 90% <100%> (+0.66%) ⬆️
types/cast.go 65.03% <100%> (ø) ⬆️
types/resolve.go 83.87% <100%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f0b34...1f4aeec. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


tests/array.c, line 127 at r1 (raw file):

    int **e[4];
    e[0] = d;
    is_eq(*(e[0][1]), 22);

Wow, this is great 👍


Comments from Reviewable

@elliotchance elliotchance merged commit 0820d77 into elliotchance:master Nov 2, 2017
@elliotchance elliotchance changed the title Fixed sizeof(char *const [5]) #286 Fixed sizeof(char *const [5]). Fixes #286 (#310) Nov 2, 2017
@elliotchance elliotchance changed the title Fixed sizeof(char *const [5]). Fixes #286 (#310) Fixed sizeof(char *const [5]). Fixes #286 Nov 2, 2017
@yulvil yulvil deleted the constarr branch November 2, 2017 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants