-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed struct array initialization #264 #283
Conversation
Reverted code from newDeclStmt and moved the array initialization logic to the transpileInitListExpr function
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 81.78% 81.78% +<.01%
==========================================
Files 136 136
Lines 5513 5524 +11
==========================================
+ Hits 4509 4518 +9
- Misses 802 803 +1
- Partials 202 203 +1
Continue to review full report at Codecov.
|
@elliotchance Let me know if there is anything to change. |
Reviewed 5 of 5 files at r1. ast/init_list_expr_test.go, line 15 at r1 (raw file):
I'm surprised this actually worked (matched the regex) with the Comments from Reviewable |
Conflicts: tests/array.c
Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion. ast/init_list_expr_test.go, line 15 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Reverted code from newDeclStmt and moved the array initialization
logic to the transpileInitListExpr function
Ref: #264
This change is