Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c2go should only output TestApp() when running in test. Fixes #267 #274

Merged
merged 3 commits into from
Oct 31, 2017

Conversation

elliotchance
Copy link
Owner

@elliotchance elliotchance commented Oct 25, 2017

This change is Reviewable

@Konstantin8105
Copy link
Contributor

Konstantin8105 commented Oct 26, 2017

Please check - adding here import "os"

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #274 into master will increase coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   81.78%   82.35%   +0.56%     
==========================================
  Files         136      136              
  Lines        5513     5691     +178     
==========================================
+ Hits         4509     4687     +178     
- Misses        802      803       +1     
+ Partials      202      201       -1
Impacted Files Coverage Δ
transpiler/transpiler.go 93.41% <100%> (+1.82%) ⬆️
main.go 53.17% <100%> (ø) ⬆️
transpiler/declarations.go 97.63% <100%> (ø) ⬆️
ast/parm_var_decl.go 83.67% <0%> (-4.9%) ⬇️
ast/init_list_expr.go 86.2% <0%> (-2.69%) ⬇️
program/import.go 100% <0%> (ø) ⬆️
program/function_definition.go 100% <0%> (ø) ⬆️
transpiler/binary.go 70.06% <0%> (+1.27%) ⬆️
types/cast.go 64.78% <0%> (+1.4%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24a0df...fd32641. Read the comment docs.

@elliotchance
Copy link
Owner Author

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 35a4bf2 into master Oct 31, 2017
@elliotchance elliotchance deleted the issue-267 branch October 31, 2017 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants