-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement goto. Fixes #269 #271
Conversation
This was causing a panic while transpiling sqlite3.c
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 81.5% 81.78% +0.28%
==========================================
Files 135 136 +1
Lines 5487 5511 +24
==========================================
+ Hits 4472 4507 +35
+ Misses 824 802 -22
- Partials 191 202 +11
Continue to review full report at Codecov.
|
Reviewed 2 of 2 files at r1. transpiler/transpiler.go, line 355 at r1 (raw file):
Please move Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. a discussion (no related file): Comments from Reviewable |
@elliotchance Sorry about the small commits. Thankfully you can do a merge-commit into your repo. |
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion. transpiler/transpiler.go, line 355 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 2 files at r2. transpiler/goto.go, line 1 at r2 (raw file):
Perfect! 👍 Comments from Reviewable |
for issue #269
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)