Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement goto. Fixes #269 #271

Merged
merged 5 commits into from
Oct 25, 2017
Merged

Implement goto. Fixes #269 #271

merged 5 commits into from
Oct 25, 2017

Conversation

yulvil
Copy link
Contributor

@yulvil yulvil commented Oct 24, 2017

for issue #269


This change is Reviewable

This was causing a panic while transpiling sqlite3.c
@codecov
Copy link

codecov bot commented Oct 24, 2017

Codecov Report

Merging #271 into master will increase coverage by 0.28%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage    81.5%   81.78%   +0.28%     
==========================================
  Files         135      136       +1     
  Lines        5487     5511      +24     
==========================================
+ Hits         4472     4507      +35     
+ Misses        824      802      -22     
- Partials      191      202      +11
Impacted Files Coverage Δ
transpiler/transpiler.go 91.58% <100%> (+0.24%) ⬆️
transpiler/goto.go 77.77% <77.77%> (ø)
main.go 53.17% <0%> (+0.57%) ⬆️
ast/position.go 83.83% <0%> (+1.5%) ⬆️
ast/go_stmt.go 78.94% <0%> (+21.05%) ⬆️
ast/label_stmt.go 88.88% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b8dd9...a7bef8d. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


transpiler/transpiler.go, line 355 at r1 (raw file):

}

func transpileLabelStmt(n *ast.LabelStmt, p *program.Program) (*goast.LabeledStmt, error) {

Please move transpileLabelStmt and transpileGotoStmt into a new file transpiler/goto.go. I want to keep this file free from pollution.


Comments from Reviewable

@elliotchance
Copy link
Owner

Review status: all files reviewed at latest revision, 2 unresolved discussions.


a discussion (no related file):
There was only one minor change -- great PR!


Comments from Reviewable

@yulvil
Copy link
Contributor Author

yulvil commented Oct 24, 2017

@elliotchance Sorry about the small commits. Thankfully you can do a merge-commit into your repo.

@yulvil
Copy link
Contributor Author

yulvil commented Oct 24, 2017

Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.


transpiler/transpiler.go, line 355 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

Please move transpileLabelStmt and transpileGotoStmt into a new file transpiler/goto.go. I want to keep this file free from pollution.

Done.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


transpiler/goto.go, line 1 at r2 (raw file):

// This file contains functions for transpiling goto/label statements.

Perfect! 👍


Comments from Reviewable

@elliotchance elliotchance changed the title Implement goto (issue #269) Implement goto. Fixes #269 Oct 24, 2017
@elliotchance elliotchance merged commit e628b45 into elliotchance:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants