-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic support for array initialization. Fixes #250 #256
Conversation
@elliotchance I can remove the commented test cases if you want. They need to be fixed at a later time. |
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 81% 81.35% +0.35%
==========================================
Files 134 134
Lines 5448 5471 +23
==========================================
+ Hits 4413 4451 +38
+ Misses 841 827 -14
+ Partials 194 193 -1
Continue to review full report at Codecov.
|
Reviewed 2 of 2 files at r1. tests/array.c, line 44 at r1 (raw file):
If I saw someone do that in code I would expect that it was a mistake. What is the expected behaviour of this in C? Please open an issue with these examples so they can be removed (rather than commented out). tests/array.c, line 75 at r1 (raw file):
In previous versions I treated tests/array.c, line 95 at r1 (raw file):
Based on my previous comment. It is better to put these examples in a Github issue so they can be found and fixed rather than keeping them as code that is inactive. Comments from Reviewable |
Review status: 1 of 2 files reviewed at latest revision, 3 unresolved discussions. tests/array.c, line 44 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. tests/array.c, line 75 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. tests/array.c, line 95 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
This change is