Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable bit for output file #245

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Remove executable bit for output file #245

merged 1 commit into from
Oct 17, 2017

Conversation

crvv
Copy link
Contributor

@crvv crvv commented Oct 17, 2017

The output Go file is not executable, so I think the executable bit should be removed.


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files         134      134           
  Lines        5328     5328           
=======================================
  Hits         4305     4305           
  Misses        834      834           
  Partials      189      189
Impacted Files Coverage Δ
main.go 52.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284a57a...a1cfa3c. Read the comment docs.

@elliotchance elliotchance changed the title remove executable bit for output file Remove executable bit for output file Oct 17, 2017
@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 1d3ffc7 into elliotchance:master Oct 17, 2017
@elliotchance
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants