Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature for unused type #234

Closed
wants to merge 2 commits into from
Closed

Add feature for unused type #234

wants to merge 2 commits into from

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Oct 5, 2017 •
edited by elliotchance
Loading

Created for #232

Now, added cleaning by unused type.
Question:

  • We don't use vendoring. For that feature added 2 library "honnef.co/go/tools/...", but we don't have a vendor instrument like golang/dep
  • Not clear - How to change snapshots for command line flags
  • Have fail test on my laptop:
# github.com/elliotchance/c2go/build/tests/stdlib
build/tests/stdlib/main_test.go:36: undefined: pthread_attr_t
build/tests/stdlib/main_test.go:39: undefined: pthread_attr_t
build/tests/stdlib/main_test.go:44: undefined: pthread_attr_t
...

For future - we can add removing unused function, constants, variables.

This change is Reviewable

@Konstantin8105
Copy link
Contributor Author

Konstantin8105 commented Oct 5, 2017 •
edited
Loading

Add issue for solving wrong result of unused library:
dominikh/go-tools#199

@Konstantin8105
Copy link
Contributor Author

PR not ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Konstantin8105