Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active status error for component NavBottom #264

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Dec 1, 2022

fix: #265

The active style on the navigation bar is not updated after switching pages.

Browser: Safari
System: MacOS and iOS

RPReplay_Final1669873139.mp4

@stackblitz
Copy link

stackblitz bot commented Dec 1, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 4be3c8c
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/638845a451ff700009124f00
😎 Deploy Preview https://deploy-preview-264--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu
Copy link
Member

antfu commented Dec 1, 2022

That's a weird behaviour of Safari 😇. And we probably have this issue on any icons.

We could instead change the icons preset with:

    presetIcons({
      scale: 1.2,
      extraProperties: {
        color: 'inherit',
      },
    }),

I'll consider including it as default in UnoCSS directly

@LittleSound
Copy link
Member Author

Thanks for the suggestion. I have added the style for the icon globally: color: 'inherit'.

@sxzz sxzz merged commit e951b05 into main Dec 1, 2022
@sxzz sxzz deleted the fix/nav-bottom-active-class-itIs-invalid branch December 1, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active status error for component NavBottom
3 participants