Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the comma after collaped or grouped mentions #2464 #2580

Closed
wants to merge 2 commits into from

Conversation

HawtinZeng
Copy link

No description provided.

Copy link

stackblitz bot commented Jan 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 28, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit e55c3e9
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65b61ab2c072c90008fb36b0

Copy link

netlify bot commented Jan 28, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit e55c3e9
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65b61ab2fb0e4b0008ad1dfc
😎 Deploy Preview https://deploy-preview-2580--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin
Copy link
Member

can you send another PR for the no-cors in the request?

@HawtinZeng
Copy link
Author

HawtinZeng commented Feb 24, 2024 via email

@HawtinZeng
Copy link
Author

HawtinZeng commented Feb 25, 2024

can you send another PR for the no-cors in the request?

Hi, after check the docs about no-cors, I think it's wrong to use it send cors request, no-cors just filter out all cors request. So I deleted it, and i accidently closed this PR, the updated PR is #2620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants