Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable window draging by the title bar #29

Merged
merged 6 commits into from
Jan 19, 2023

Conversation

piotrski
Copy link
Member

elk-zone/elk#1268 needs to be merged first
Resolves #10

@stackblitz
Copy link

stackblitz bot commented Jan 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

elk-zone/elk#1268 is merged now 👍🏼

@piotrski
Copy link
Member Author

@JonasKruckenberg do you know why audit rust is failing?

@JonasKruckenberg
Copy link
Collaborator

@JonasKruckenberg do you know why audit rust is failing?

Should be fixed now, please rebase 👍🏻

@JonasKruckenberg
Copy link
Collaborator

I don't really like how this box is the only area that is draggable, but I guess we need a better overall desktop layout anyway for this to change

Screenshot 2023-01-19 at 11 33 23

@piotrski
Copy link
Member Author

Yes. It was just a quick fix. We need to work on desktop layout.

@JonasKruckenberg
Copy link
Collaborator

Yes. It was just a quick fix. We need to work on desktop layout.

yeah I'm going to merge this for the time being, as some dragging is already better than no dragging 👍🏻

@JonasKruckenberg JonasKruckenberg merged commit 2eb4a8a into elk-zone:main Jan 19, 2023
@github-actions github-actions bot mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: Cannot drag window around
3 participants