fix: Text2Image interface refactored #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomguluson92
changed the title
monilpat
requested changes
Dec 2, 2024
| @@ -843,16 +838,18 @@ export const generateImage = async ( | |||
| const imageURL = await response.json(); | |||
| return { success: true, data: [imageURL] }; | |||
| } else if ( | |||
| // TODO: Fix LLAMACLOUD -> Together? | |||
There was a problem hiding this comment.
Might be good to either remove or add an issue # to it!
| runtime.imageModelProvider === ModelProviderName.LLAMACLOUD | ||
| ) { | ||
| const together = new Together({ apiKey: apiKey as string }); | ||
| // Fix: steps 4 is for schnell; 28 is for dev. |
| width: 1024, | ||
| height: 1024, | ||
| count: 1, | ||
| ...(options.width !== undefined ? { width: options.width || 1024 } : {}), |
There was a problem hiding this comment.
instead of !== undefined you probably want to do != null which checks for undefined or null
|
As well as address the CI linter failure and add a test plan if you can thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: Text2Image plugin
Risks
Low
Background
Uniform interface and parameters and allow for flexible options input.
What does this PR do?
Upgrade the input parameter for sophisticated effect in ALL T2I interfaces.
What kind of change is this?
Updates
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps