Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (voice) enhance character card voice configuration support #698

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

augchan42
Copy link
Contributor

feat(voice): enhance character card voice configuration support

  • Add comprehensive ElevenLabs configuration in character cards
  • Make ElevenLabs settings optional with sensible defaults
  • Implement configuration priority (character card > env vars > defaults)
  • Update schema validation to support optional fields
  • Add debug logging for voice selection process
  • Maintain backward compatibility with existing setups

Example character card config:

{
    "settings": {
        "voice": {
            "model": "en_GB-alan-medium",
            "elevenlabs": {
                "voiceId": "your-voice-id",
                "model": "eleven_monolingual_v1",
                "stability": "0.5"
            }
        }
    }
}

Closes #694

@augchan42 augchan42 changed the title feat(voice): enhance character card voice configuration support feat: (voice) enhance character card voice configuration support Nov 30, 2024
@augchan42
Copy link
Contributor Author

BTW this PR also fixes the web-agent/vite build issues

@shakkernerd
Copy link
Member

BTW this PR also fixes the web-agent/vite build issues

This is already fixed on recent main.

@shakkernerd
Copy link
Member

Can you start by resolving the conflicts and why are there so many changed files? It says 141 files right now.

@augchan42
Copy link
Contributor Author

augchan42 commented Nov 30, 2024 via email

- Add comprehensive ElevenLabs configuration in character cards
- Make ElevenLabs settings optional with sensible defaults
- Implement configuration priority (character card > env vars > defaults)
- Update schema validation to support optional fields
- Add debug logging for voice selection process
- Maintain backward compatibility with existing setups

Example character card config:
```json
{
    "settings": {
        "voice": {
            "model": "en_GB-alan-medium",
            "elevenlabs": {
                "voiceId": "your-voice-id",
                "model": "eleven_monolingual_v1",
                "stability": "0.5"
            }
        }
    }
}
```

Closes elizaOS#694
@augchan42 augchan42 force-pushed the fix/character-voice-settings branch from d2690af to 607daa9 Compare November 30, 2024 09:30
@augchan42
Copy link
Contributor Author

From 141 files to 8, I re-ran the build and it works after removing the web-agent folder (had to fix target in package.json)

@lalalune lalalune merged commit 84466c4 into elizaOS:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat-Enhanced Voice Configuration Support in Character Cards
3 participants