refactor: better db connection handling #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
approved these changes
Nov 28, 2024
cygaar
changed the title
cygaar
force-pushed
the
better_db_handling
branch
from
bb4d986 to
91c6ae3
Compare
lalalune
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Better closing of db connections to prevent dangling connections
Risks
Low
Background
What does this PR do?
This PR adds code to gracefully close db connections. This will be useful when we allow clients to be stopped (right now only starting is supported)
What kind of change is this?
Improvements
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Ran tests locally, let me know if there's a better way to test this.
Where should a reviewer start?
Detailed testing steps