fix: small improvements to agent process exits #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
changed the title
|
I will give this a check in a bit, thanks!! |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
N/A
Risks
Low, just a refactor and adding SIGTERM handling
Background
What does this PR do?
We catch SIGTERM and refactor a bit of code. In the future we can use the
gracefulExitfunction to clean up DB and client resources as well.What kind of change is this?
Small process management improvements
Documentation changes needed?
Nope
Testing
Where should a reviewer start?
Running an agent locally and exiting through an exit prompt or ctrl + c
Detailed testing steps