fix: enable test run in CI for core package #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkbrooks can you run the workflow? |
pgoos
commented
Nov 25, 2024
| @@ -5,7 +5,7 @@ export const defaultCharacter: Character = { | |||
| username: "eliza", | |||
| plugins: [], | |||
| clients: [], | |||
| modelProvider: ModelProviderName.LLAMALOCAL, | |||
| modelProvider: ModelProviderName.OLLAMA, | |||
There was a problem hiding this comment.
@lalalune test packages/core/src/defaultCharacter.ts was failing because of that change to LLAMALOCAL. Was that change intentional? I switched back to OLLAMA
snobbee
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Low
Background
What does this PR do?
Enables running tests as part of CI
What kind of change is this?
Improvement
Why are we doing this? Any context or related work?
We need to make sure no breaking changes (regressions) are introduced with new PRs
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
locally run tests
tests run in CI
Where should a reviewer start?
Detailed testing steps
None, automtated tests are fine.
Discord username
piotrg5517