Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignored modelEndpointOverride in generation #446

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

darwintree
Copy link
Contributor

Background

What does this PR do?

This PR fixes the issue of OpenAi object initialization which ignores the modelEndpointOverride optioin of the character

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

@ponderingdemocritus
Copy link
Contributor

will this break if it is nul?

@snobbee
Copy link
Contributor

snobbee commented Nov 20, 2024

Thanks @darwintree for addressing the issue with OpenAI object initialization and ensuring the modelEndpointOverride is respected. Could you please add a test to validate the changes made in this PR? Specifically:

  1. A test to ensure that the baseURL is properly set when modelEndpointOverride is provided.
  2. A test to verify that the functionality does not break when modelEndpointOverride (or baseURL) is null or undefined.

This will help confirm that the changes work as expected and ensure robustness. Let me know if you need further clarification or help setting up the test!

@darwintree
Copy link
Contributor Author

will this break if it is nul?

Thanks, I ignored the situation that it could be null. A fix is commited to resolve the issue

@darwintree
Copy link
Contributor Author

Thanks @darwintree for addressing the issue with OpenAI object initialization and ensuring the modelEndpointOverride is respected. Could you please add a test to validate the changes made in this PR? Specifically:

  1. A test to ensure that the baseURL is properly set when modelEndpointOverride is provided.
  2. A test to verify that the functionality does not break when modelEndpointOverride (or baseURL) is null or undefined.

This will help confirm that the changes work as expected and ensure robustness. Let me know if you need further clarification or help setting up the test!

Hi, would know how to setup and run the test. Thanks

@ponderingdemocritus ponderingdemocritus merged commit 693600b into elizaOS:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants