-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: .env Namespaced Character Secrets #410
Conversation
Thanks for getting this out! Great work! Given it is of medium risk, can we add a quick unit test to confirm that the cascading logic (in terms of where to read the settings) works as expected. If you don't want to include this in this PR no worries create a ticket and TODO comment. But please confirm on your machine that the precedence is honored re:
Thanks so much! |
good idea, I'll add tests. Is the suite in pretty good condition? I didn't try yet. |
replaced by #1454 which fixed conflicts |
Relates to:
N/A
Risks
Medium - This PR adds a new feature for character-specific environment variable namespacing.
Risks include:
Background
I wanted to be able to check in character files without having to sanitize them first
What does this PR do?
Feature Implementation
Adds support for character-specific namespaced environment variables:
CHARACTER.YOUR_CHARACTER_NAME.SETTING_NAME
Key changes:
packages/core/src/settings.ts
packages/agent/src/index.ts
Documentation Updates
Updated documentation to reflect the new feature:
What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
Yes - Documentation has been updated to reflect the new feature:
Testing
Where should a reviewer start?
Feature Testing
Review code changes:
packages/core/src/settings.ts
packages/agent/src/index.ts
Test functionality:
Documentation Testing
Review updated docs:
Detailed testing steps
Feature Testing:
Documentation Verification:
Screenshots
N/A - Feature implementation and documentation changes