-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TwitterInteractionClient response handling and boredom provider #384
Conversation
Please update the PR to pass the PR Title Check thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM need some minor clean up please address then will approve!
Added TODO comments for elizaOS#408 to review and update the `totalMessages` logic.
Everything commited and issue #408 created! Thank you |
Amazing - thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing comments!
@monilpat you sure? we have conflicts in |
I can't see the conflicts somehow. That is so weird. Yes - please resolve the conflicts first. Sending back to reviewer. |
@DanielHighETH would you fix the merge conflict in |
@jkbrooks @monilpat a new code was merged 3 hours ago from #383 I'm not really sure if we should use my refractored code in this new code |
@DanielHighETH looks like there is still some value in your PR, even though we also have #383 Please let us know if you think you can get to the merge conflict, we are still happy to merge. Otherwise, no worries, we can close this PR. |
Thanks for doing this and addressing all comments. Sorry to bother you again, but can we add any tests or screengrabs confirming that this does in fact improve the conversation and address? https://x.com/shawmakesmagic/status/1858248520060567911 |
Hey, I have no idea how to do it actually |
Relates to:
https://x.com/shawmakesmagic/status/1858248520060567911
Risks
Low
What does this PR do?