Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App running on configurations from .env #38

Closed
wants to merge 2 commits into from
Closed

App running on configurations from .env #38

wants to merge 2 commits into from

Conversation

FabriceIRANKUNDA
Copy link
Contributor

No description provided.

@FabriceIRANKUNDA FabriceIRANKUNDA linked an issue Oct 26, 2024 that may be closed by this pull request
Make sure app runs purely on char files, no process.env, and vice versa #30
Closed
@sirkitree
Copy link
Collaborator

Thanks for your contribution :)

I am looking through this and while the formatting changes look reasonable, I'm not sure that it actually solves anything.

Would you mind helping me understand

  1. What your change aims to accomplish
  2. How it helps solve the linked issue
  3. Describe some testing steps I could take to verify on my end

Noting there is also a conflict to resolve.

@FabriceIRANKUNDA FabriceIRANKUNDA deleted the Ft-Env-Configurstions branch October 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalalune lalalune Awaiting requested review from lalalune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure app runs purely on char files, no process.env, and vice versa
2 participants
@FabriceIRANKUNDA @sirkitree