added clientConfig to optionally ignore bots and DMs #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Low to none
Background
What does this PR do?
Adds clientConfig to Character type and handle ignore DM and ignore bots logic in Telegram & Discord clients
What kind of change is this?
An improvement to prevent abuse
Why are we doing this? Any context or related work?
Bots keep draining each other's credits in #the-arena. On Telegram, they are also affected by buy bots etc. I think "ignoreBots" configuration option is needed. DMs are also a concern because it's easy to purchase Telegram/Discord accounts and drain anyone's credits. The "[IGNORE]" feature alone is not a sufficient solution.
Testing
Add
"clientConfig": { "discord": { "shouldIgnoreBotMessages": true, "shouldIgnoreDirectMessages": true }, "telegram": { "shouldIgnoreBotMessages": true, "shouldIgnoreDirectMessages": true } }to character.json file. All fields are optional.