fix: 3328 fix Amazon Bedrock as LLM provider #3329
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/core/src/generation.ts
Outdated
| case ModelProviderName.BEDROCK: { | ||
| elizaLogger.debug("Initializing Bedrock model."); | ||
|
|
||
| const { text: bedrockResponse } = await aiGenerateText({ | ||
| model: bedrock(model), | ||
| maxSteps: maxSteps, | ||
| temperature: temperature, | ||
| maxTokens: max_response_length, | ||
| frequencyPenalty: frequency_penalty, | ||
| presencePenalty: presence_penalty, | ||
| experimental_telemetry: experimental_telemetry, | ||
| }); | ||
|
|
||
| response = bedrockResponse; | ||
| elizaLogger.debug("Received response from Bedrock model."); | ||
| } |
There was a problem hiding this comment.
Missing break statement after the BEDROCK case block will cause execution to fall through to the default case. This means the code will log an "Unsupported provider" error even after successfully handling Bedrock requests. Adding break; before the default case will resolve this issue.
| case ModelProviderName.BEDROCK: { | |
| elizaLogger.debug("Initializing Bedrock model."); | |
| const { text: bedrockResponse } = await aiGenerateText({ | |
| model: bedrock(model), | |
| maxSteps: maxSteps, | |
| temperature: temperature, | |
| maxTokens: max_response_length, | |
| frequencyPenalty: frequency_penalty, | |
| presencePenalty: presence_penalty, | |
| experimental_telemetry: experimental_telemetry, | |
| }); | |
| response = bedrockResponse; | |
| elizaLogger.debug("Received response from Bedrock model."); | |
| } | |
| case ModelProviderName.BEDROCK: { | |
| elizaLogger.debug("Initializing Bedrock model."); | |
| const { text: bedrockResponse } = await aiGenerateText({ | |
| model: bedrock(model), | |
| maxSteps: maxSteps, | |
| temperature: temperature, | |
| maxTokens: max_response_length, | |
| frequencyPenalty: frequency_penalty, | |
| presencePenalty: presence_penalty, | |
| experimental_telemetry: experimental_telemetry, | |
| }); | |
| response = bedrockResponse; | |
| elizaLogger.debug("Received response from Bedrock model."); | |
| break; | |
| } |
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
odilitime
changed the title
|
Hello, We are changing our plugin development strategy to be more scalable. We have moved the plugins out into their own repos and we're looking for people to either maintain those or own them on their own Github. If you'd like to be a maintainer, file an issue in the plugin repo and join our Discord https://discord.gg/elizaos to coordinate. If you'd like to control the plugin on your own Github, please add an issue to the plugin repo pointing to your repo, and add a modification to the registry. Submit a PR to edit the registry here: https://github.com/elizaos-plugins/registry Closing this PR for now. Let us know if you have any questions. |
Relates to
Fixes 3328
Risks
Low risk as this only adds one case statement for handling the Bedrock model provider
Background
What does this PR do?
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps