-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach Zilliqa plugin about PlunderSwap currency exchange. #3267
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mtbc! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
e2be2ba
to
e723d52
Compare
48c5443
to
bfd6aec
Compare
2156818
to
28ac59a
Compare
28ac59a
to
2b4d859
Compare
Hello, We are changing our plugin development strategy to be more scalable. We have moved the plugins out into their own repos and we're looking for people to either maintain those or own them on their own Github. Please make your code changes to this repo: https://github.com/elizaos-plugins/plugin-zilliqa If you'd like to be a maintainer, file an issue in the plugin repo and join our Discord https://discord.gg/elizaos to coordinate. If you'd like to control the plugin on your own Github, please add an issue to the plugin repo pointing to your repo, and add a modification to the registry. Submit a PR to edit the registry here: https://github.com/elizaos-plugins/registry Closing this PR for now. Let us know if you have any questions. |
Thanks @odilitime, I'll look to do that. From the point of view of developing against https://github.com/elizaos-plugins/plugin-zilliqa, what to do about it claiming,
when it's not in the workspace any more? I don't see git submodules being used anywhere. Are there some tips for setting things up locally so that I can build the plugin and run it with an agent? |
Relates to
No issue or ticket.
Risks
Simply adds more actions to the Zilliqa plugin.
Introduces a dependency on the GOAT plunderswap plugin.
Worst risk is that somehow the LLM mangles data so that the user swaps the wrong amount of the wrong currency. However, the GOAT plugin is written to deposit always back into the same wallet so, at worst, the user just has to swap to what they wanted originally.
Background
What does this PR do?
Adds actions to ZIlliqa plugin, under the auspices of a related plugin class
ZilliqaEvmPlugin
, that allow Eliza to drive GOAT's plugin for PlunderSwap.What kind of change is this?
Features (non-breaking change which adds functionality)
Why are we doing this? Any context or related work?
This allows users to do currency exchanges using PlunderSwap's V2 liquidity pool on Zilliqa's chain.
It includes actions for converting Zilliqa's native ZIL token to WZIL (wrapped ZIL) which also has liquidity in the pool, and for converting it back to native ZIL, enabling a user to start with ZIL and end up with anything available in the token reserves.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Detailed testing steps
Populate
ZILLIQA_PRIVATE_KEY
in the environment. If you invent some new key for an EVM wallet, you can get some native ZIL for it from https://dev-wallet.zilliqa.com/faucet?network=testnet.Set
ZILLIQA_PROVIDER_URL
to https://api.testnet.zilliqa.comSee the screenshots for the kinds of interaction one can do. Probably start by wrapping most but not all ZIL that the faucet gave you:
Whenever you do transactions whose hashes are reported, you can see them in the block explorer by postfixing https://otterscan.testnet.zilliqa.com/tx/ with the hash.
Screenshots
After
Deploy Notes
Deployment instructions
See notes above about
ZILLIQA_PRIVATE_KEY
andZILLIQA_PROVIDER_URL
.