-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(plugin-new): initia plugin + chore revert to integrationTests from stable release 0.1.7" #2602
Conversation
…Tests f…" This reverts commit e80c2e6.
📝 WalkthroughWalkthroughThe pull request comprehensively removes the Initia Plugin from the project ecosystem. This involves deleting the entire plugin package, removing its configuration entries, eliminating import statements, and cleaning up related workflow and dependency references. The changes suggest a complete deprecation of the Initia Plugin functionality across the project's infrastructure. Changes
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/smoke-tests.yml (1)
20-27
: Optimize cache configuration.The cache configuration looks good, but consider:
- Adding a hash of your test files to the cache key
- Using compression for the cache
.github/workflows/integrationTests.yaml (1)
41-45
: Scope API keys to integration tests only.Good practice moving the API keys to the specific step. Consider adding timeouts to the integration tests to prevent hanging builds.
run: pnpm run integrationTests + timeout-minutes: 30
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.env.example
(0 hunks).github/workflows/integrationTests.yaml
(1 hunks).github/workflows/smoke-tests.yml
(1 hunks)agent/package.json
(0 hunks)agent/src/index.ts
(0 hunks)packages/plugin-initia/README.md
(0 hunks)packages/plugin-initia/package.json
(0 hunks)packages/plugin-initia/src/actions/transfer.ts
(0 hunks)packages/plugin-initia/src/index.ts
(0 hunks)packages/plugin-initia/src/providers/wallet.ts
(0 hunks)packages/plugin-initia/src/types/const.ts
(0 hunks)packages/plugin-initia/tsconfig.json
(0 hunks)packages/plugin-initia/tsup.config.ts
(0 hunks)
💤 Files with no reviewable changes (11)
- packages/plugin-initia/README.md
- agent/package.json
- packages/plugin-initia/tsconfig.json
- packages/plugin-initia/tsup.config.ts
- agent/src/index.ts
- packages/plugin-initia/src/index.ts
- packages/plugin-initia/src/types/const.ts
- .env.example
- packages/plugin-initia/package.json
- packages/plugin-initia/src/actions/transfer.ts
- packages/plugin-initia/src/providers/wallet.ts
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/integrationTests.yaml
[error] 29-29: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: smoke-tests
- GitHub Check: integration-tests
- GitHub Check: integration-tests
- GitHub Check: integration-tests
🔇 Additional comments (2)
.github/workflows/smoke-tests.yml (1)
13-14
: Consider using an LTS Node.js version.Using Node.js 23 in production CI/CD might lead to stability issues. Additionally, pin the container image to a specific version for reproducibility.
.github/workflows/integrationTests.yaml (1)
18-19
: Consider using an LTS Node.js version.Node.js 23.3 is not an LTS version. Consider using Node.js 20 LTS for better stability.
env: | ||
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Scope the OPENAI_API_KEY to specific steps.
Move the API key to the specific step that needs it to minimize exposure.
- env:
- OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
Committable suggestion skipped: line range outside the PR's diff.
version: 9.15.0 | ||
|
||
- name: Install dependencies | ||
run: pnpm install --no-frozen-lockfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove --no-frozen-lockfile flag.
Using --no-frozen-lockfile
can lead to inconsistent dependency versions across builds. Remove this flag to ensure reproducible builds.
- run: pnpm install --no-frozen-lockfile
+ run: pnpm install
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
run: pnpm install --no-frozen-lockfile | |
run: pnpm install |
Reverts #2448
Summary by CodeRabbit
Configuration Changes
.env.example
CI/CD Updates
Dependency Removal
@elizaos/plugin-initia
dependency from agent packageThe changes indicate a complete removal of the Initia Plugin from the project, including configuration, code, and related workflows.