Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(plugin-new): initia plugin + chore revert to integrationTests from stable release 0.1.7" #2602

Closed
wants to merge 1 commit into from

Conversation

wtfsayo
Copy link
Member

@wtfsayo wtfsayo commented Jan 21, 2025

Reverts #2448

Summary by CodeRabbit

  • Configuration Changes

    • Removed Initia Plugin configuration entries from .env.example
    • Removed Initia Plugin package and related files
  • CI/CD Updates

    • Updated GitHub Actions workflows for integration and smoke tests
    • Updated Node.js and pnpm versions
    • Added new environment variable for Coinbase Commerce
  • Dependency Removal

    • Removed @elizaos/plugin-initia dependency from agent package
    • Deleted Initia Plugin package and its source files

The changes indicate a complete removal of the Initia Plugin from the project, including configuration, code, and related workflows.

Copy link
Contributor

coderabbitai bot commented Jan 21, 2025

📝 Walkthrough

Walkthrough

The pull request comprehensively removes the Initia Plugin from the project ecosystem. This involves deleting the entire plugin package, removing its configuration entries, eliminating import statements, and cleaning up related workflow and dependency references. The changes suggest a complete deprecation of the Initia Plugin functionality across the project's infrastructure.

Changes

File Change Summary
.env.example Removed Initia Plugin configuration entries
.github/workflows/integrationTests.yaml Updated Node.js and pnpm versions, added caching, modified environment variables
.github/workflows/smoke-tests.yml Updated to use Node.js container, upgraded pnpm version, added dependency caching
agent/package.json Removed @elizaos/plugin-initia dependency
agent/src/index.ts Removed initiaPlugin import
packages/plugin-initia/ Completely removed plugin package, including README, package configuration, source files, and TypeScript configuration

Possibly related PRs


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
.github/workflows/smoke-tests.yml (1)

20-27: Optimize cache configuration.

The cache configuration looks good, but consider:

  1. Adding a hash of your test files to the cache key
  2. Using compression for the cache
.github/workflows/integrationTests.yaml (1)

41-45: Scope API keys to integration tests only.

Good practice moving the API keys to the specific step. Consider adding timeouts to the integration tests to prevent hanging builds.

  run: pnpm run integrationTests
+ timeout-minutes: 30
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e80c2e6 and e68ce97.

📒 Files selected for processing (13)
  • .env.example (0 hunks)
  • .github/workflows/integrationTests.yaml (1 hunks)
  • .github/workflows/smoke-tests.yml (1 hunks)
  • agent/package.json (0 hunks)
  • agent/src/index.ts (0 hunks)
  • packages/plugin-initia/README.md (0 hunks)
  • packages/plugin-initia/package.json (0 hunks)
  • packages/plugin-initia/src/actions/transfer.ts (0 hunks)
  • packages/plugin-initia/src/index.ts (0 hunks)
  • packages/plugin-initia/src/providers/wallet.ts (0 hunks)
  • packages/plugin-initia/src/types/const.ts (0 hunks)
  • packages/plugin-initia/tsconfig.json (0 hunks)
  • packages/plugin-initia/tsup.config.ts (0 hunks)
💤 Files with no reviewable changes (11)
  • packages/plugin-initia/README.md
  • agent/package.json
  • packages/plugin-initia/tsconfig.json
  • packages/plugin-initia/tsup.config.ts
  • agent/src/index.ts
  • packages/plugin-initia/src/index.ts
  • packages/plugin-initia/src/types/const.ts
  • .env.example
  • packages/plugin-initia/package.json
  • packages/plugin-initia/src/actions/transfer.ts
  • packages/plugin-initia/src/providers/wallet.ts
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/integrationTests.yaml

[error] 29-29: trailing spaces

(trailing-spaces)


[error] 34-34: trailing spaces

(trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: smoke-tests
  • GitHub Check: integration-tests
  • GitHub Check: integration-tests
  • GitHub Check: integration-tests
🔇 Additional comments (2)
.github/workflows/smoke-tests.yml (1)

13-14: Consider using an LTS Node.js version.

Using Node.js 23 in production CI/CD might lead to stability issues. Additionally, pin the container image to a specific version for reproducibility.

.github/workflows/integrationTests.yaml (1)

18-19: Consider using an LTS Node.js version.

Node.js 23.3 is not an LTS version. Consider using Node.js 20 LTS for better stability.

Comment on lines +15 to +16
env:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Scope the OPENAI_API_KEY to specific steps.

Move the API key to the specific step that needs it to minimize exposure.

- env:
-     OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}

Committable suggestion skipped: line range outside the PR's diff.

version: 9.15.0

- name: Install dependencies
run: pnpm install --no-frozen-lockfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove --no-frozen-lockfile flag.

Using --no-frozen-lockfile can lead to inconsistent dependency versions across builds. Remove this flag to ensure reproducible builds.

- run: pnpm install --no-frozen-lockfile
+ run: pnpm install
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: pnpm install --no-frozen-lockfile
run: pnpm install

@wtfsayo wtfsayo closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant