Startup Error: ENV misconfig

[0xSero]

Relates to

No specific issue ticket.

Risks

Low - This is a minor validation improvement that makes the URL check more robust.

Background

What does this PR do?

Character start fails due to lack of a env
Improves the URL validation check in the hasValidRemoteUrls() function to be more stable by ensuring URLs start with "http" rather than just checking for non-empty strings.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Look at the hasValidRemoteUrls() function in agent/src/index.ts:

// Before:
const hasValidRemoteUrls = () =>
    process.env.REMOTE_CHARACTER_URLS &&
    process.env.REMOTE_CHARACTER_URLS !== "";

// After:
const hasValidRemoteUrls = () =>
    process.env.REMOTE_CHARACTER_URLS &&
    process.env.REMOTE_CHARACTER_URLS !== "" &&
    process.env.REMOTE_CHARACTER_URLS.startsWith("http");

Detailed testing steps

1. Set REMOTE_CHARACTER_URLS environment variable to various values:
   • Valid URL: http://example.com - should return true
   • Invalid URL: not-a-url - should return false
   • Empty string: "" - should return false
   • Undefined - should return false

Discord username

0xsero

[wtfsayo]

thanks got this covered in #2384 pretty close