fix: don't force root for install #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakkernerd
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Low
Background
Currently pnpm install on linux (and probably mac etc) is doing a
npx playwright install-depsfor the post postinstall script on plugin-node. This forces a super user login for root access which is a huge red flag and generally a bad practice.What does this PR do?
Removes the root privileged command and in the rare case the user does not have the required dependencies prints a console message on how to fix. This way users aren't blindly trusting what calls are being made with super user privileges.
What kind of change is this?
Bug fix
Documentation changes needed?
None