fix: prevent repeated login by reusing client-twitter session #2129
+115
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcm390
force-pushed
the
tcm-fix-plugin-twitter
branch
from
746b3fe to
6e61d9e
Compare
shakkernerd
approved these changes
Jan 10, 2025
0xpi-ai
pushed a commit
to 0xpi-ai/NayariAI
that referenced
this pull request
Jan 15, 2025
fix: prevent repeated login by reusing client-twitter session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1974 made by @mrsalitre (https://github.com/mrsalitre)
I’ve remade this PR because maintainer edit access was not enabled, making it difficult to make necessary changes directly.
Relates to
1969
Risks
Low:
Background
What does this PR do?
This PR prevents multiple logins by reusing the session created by the
client-twitterwhen posting. This resolves the twitter security alerts caused by repeated logins during post creation.What kind of change is this?
Bug fixes: fixes issue 1969
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Detailed testing steps
None: Automated and manual tests are welcome.
Deploy Notes
Database changes
Deployment instructions
Discord username
jeanayala.eth