Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include schema.sql and seed.sql in package files #2030

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

brauliolomeli
Copy link

Relates to

Fixes #2009 - @elizaos/adapter-postgres package does not bundle together schema.sql

Risks

Low - Adding missing SQL files to package bundling. Only affects package distribution, not functionality.

Background

What does this PR do?

Adds schema.sql and seed.sql files to the package.json "files" array to ensure they are properly bundled with the npm package when published.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

  1. Review the package.json changes in packages/adapter-postgres/package.json
  2. Verify the added files: schema.sql and seed.sql are included

Detailed testing steps

  1. Run pnpm install @elizaos/adapter-postgres
  2. Instantiate PostgresDatabaseAdapter
  3. Call db.init()
  4. Verify no "no such file or directory" errors occur
  5. Verify migrations run successfully

Deploy Notes

After merging, a new package version will need to be published to npm to make the fix available to users.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brauliolomeli! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@odilitime odilitime merged commit 6731b13 into elizaOS:develop Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants