Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add embedding tests #1944

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

shlokkhemani
Copy link
Contributor

@shlokkhemani shlokkhemani commented Jan 7, 2025

Risks

Low

Background

What does this PR do?

This PR adds a comprehensive test suite for the embedding.ts module. It covers local vs. remote embeddings, cached embeddings, error scenarios, and fallback logic.

What kind of change is this?

Features (non-breaking change which adds functionality)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Look at src/tests/embedding.test.ts

Discord username

shloked

Copy link
Member

@shakkernerd shakkernerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@shakkernerd shakkernerd merged commit ae56659 into elizaOS:develop Jan 7, 2025
5 checks passed
@shlokkhemani shlokkhemani deleted the add-embedding-tests branch January 7, 2025 07:52
@shlokkhemani shlokkhemani restored the add-embedding-tests branch January 7, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants