chore(core): enable strict null checks #1878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Type safety
Risks
Low
Background
What does this PR do?
Added type safety to evaluators in
packages/core/src/runtime.ts
to prevent crashes whenparseJsonArrayFromText
returns null. The fix usesevaluators?.includes
to handle potential null values. SincestrictNullChecks
is disabled, similar issues likely exist elsewhere. I enabledstrictNullChecks
in the core package and kept changes minimal, focusing on the core runtime. Downstream TypeScript errors were addressed withts-expect-error
pragmas. This approach facilitates the incremental adoption of stricter type safety.What kind of change is this?
Typescript related
Why are we doing this? Any context or related work?
The app crashes occasionally when
parseJsonArrayFromText
returns null in core runtime logic.Documentation changes needed?
No
Testing
Integration tests should catch any issues. The only real change here is a null key check on evaluators in the evaluator handler loop.
Where should a reviewer start?
Start the app, make some prompts, make sure normal prompts work as expected.
Detailed testing steps