feat: migrate generateObjectDeprecated to generateObject #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks so much for picking this up - you will need to actually change the structure here as generateObject takes in a schema (which is a z object) please review the plugin-coinbase plugins to see how this is done. checkout the types.ts file there for an example
9547
force-pushed
the
migrate-generateObjectDeprecated
branch
from
9c81aaf to
e38a18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Background
What does this PR do?
implement #1661
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps