Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lockfile wasn't updated after dependency + bring viem to root level package.json #1642

Merged
merged 15 commits into from
Jan 1, 2025

Conversation

monilpat
Copy link
Collaborator

@monilpat monilpat commented Jan 1, 2025

Relates to:

Trunk being broken

Risks

Low. This change updates the pnpm-lock.yaml file, which could affect dependency resolutions. Potential risks include:

  • Dependency Resolution Changes: Updates might lead to different versions of dependencies being installed, which could introduce unforeseen issues.

  • Build or Runtime Errors: If updated dependencies have breaking changes, they might cause build failures or runtime errors.

Background

What does this PR do?

This pull request updates the pnpm-lock.yaml file by running pnpm install -r --no-frozen-lockfile. This command installs dependencies recursively across all workspaces and refreshes the lockfile to reflect any changes in dependencies.

What kind of change is this?

  • Updates: This is a non-breaking change that updates the lockfile to ensure it accurately represents the current state of dependencies.

Why are we doing this? Any context or related work?

Updating the lockfile ensures that all dependencies are correctly resolved and that the project can be built and run consistently across different environments. This is particularly important when dependencies have been added, removed, or updated in the package.json files.

Documentation changes needed?

  • My changes do not require a change to the project documentation.

Testing

Screenshot 2025-01-01 at 12 18 56 PM

Where should a reviewer start?

Begin by reviewing the changes in the pnpm-lock.yaml file to understand the updates to dependency resolutions.

Detailed testing steps

  1. Clean Install: Run pnpm install to ensure all dependencies are installed correctly with the updated lockfile.

  2. Run Tests: Execute the test suite using pnpm test to verify that all tests pass with the updated dependencies.

  3. Build Project: Attempt to build the project using pnpm build to confirm that the build process completes successfully.

  4. Manual Verification: Run the application locally to ensure it behaves as expected with the updated dependencies.

Deploy Notes

No special deployment steps are required. Ensure that the updated pnpm-lock.yaml file is included in the deployment to maintain consistency across environments.

Database changes

None.

Deployment instructions

  1. Merge the PR into the main branch.

  2. Pull the latest changes on the deployment environment.

  3. Run pnpm install to install dependencies as per the updated lockfile.

  4. Proceed with the standard deployment process.

Discord username

N/A

@monilpat monilpat changed the title fix: lockfile wasn't updated after dependecy fix: lockfile wasn't updated after dependency Jan 1, 2025
@monilpat monilpat changed the title fix: lockfile wasn't updated after dependency fix: lockfile wasn't updated after dependency + bring viem to root level package.json Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants