-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lockfile wasn't updated after dependency + bring viem to root level package.json #1642
Merged
shakkernerd
merged 15 commits into
elizaOS:develop
from
Sifchain:realitySpiral/fixLockFile
Jan 1, 2025
Merged
fix: lockfile wasn't updated after dependency + bring viem to root level package.json #1642
shakkernerd
merged 15 commits into
elizaOS:develop
from
Sifchain:realitySpiral/fixLockFile
Jan 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
changed the title
fix: lockfile wasn't updated after dependecy
fix: lockfile wasn't updated after dependency
Jan 1, 2025
monilpat
changed the title
fix: lockfile wasn't updated after dependency
fix: lockfile wasn't updated after dependency + bring viem to root level package.json
Jan 1, 2025
odilitime
approved these changes
Jan 1, 2025
This was referenced Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Trunk being broken
Risks
Low. This change updates the
pnpm-lock.yaml
file, which could affect dependency resolutions. Potential risks include:Dependency Resolution Changes: Updates might lead to different versions of dependencies being installed, which could introduce unforeseen issues.
Build or Runtime Errors: If updated dependencies have breaking changes, they might cause build failures or runtime errors.
Background
What does this PR do?
This pull request updates the
pnpm-lock.yaml
file by runningpnpm install -r --no-frozen-lockfile
. This command installs dependencies recursively across all workspaces and refreshes the lockfile to reflect any changes in dependencies.What kind of change is this?
Why are we doing this? Any context or related work?
Updating the lockfile ensures that all dependencies are correctly resolved and that the project can be built and run consistently across different environments. This is particularly important when dependencies have been added, removed, or updated in the
package.json
files.Documentation changes needed?
Testing
Where should a reviewer start?
Begin by reviewing the changes in the
pnpm-lock.yaml
file to understand the updates to dependency resolutions.Detailed testing steps
Clean Install: Run
pnpm install
to ensure all dependencies are installed correctly with the updated lockfile.Run Tests: Execute the test suite using
pnpm test
to verify that all tests pass with the updated dependencies.Build Project: Attempt to build the project using
pnpm build
to confirm that the build process completes successfully.Manual Verification: Run the application locally to ensure it behaves as expected with the updated dependencies.
Deploy Notes
No special deployment steps are required. Ensure that the updated
pnpm-lock.yaml
file is included in the deployment to maintain consistency across environments.Database changes
None.
Deployment instructions
Merge the PR into the main branch.
Pull the latest changes on the deployment environment.
Run
pnpm install
to install dependencies as per the updated lockfile.Proceed with the standard deployment process.
Discord username
N/A