Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update package.json with build-docker command to match the dockerfile command #1527

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

vanshika-srivastava
Copy link
Contributor

@vanshika-srivastava vanshika-srivastava commented Dec 28, 2024

This PR should resolve the build issue that occurs when you run the docker file. The current command mentions build-docker in dockerfile but package.json has docker:build as the script file.

Relates to:

packages/plugin-node postinstall: Skipping playwright installation on unsupported platform: linux
packages/plugin-node postinstall: Done
Done in 17m 42s
undefined
âERR_PNPM_RECURSIVE_EXEC_FIRST_FAILâ Command "build-docker" not found
Did you mean "pnpm docker"?

Risks

Background

Dockerfile contains this command

# Install dependencies and build the project
RUN pnpm install \
    && pnpm build-docker \
    && pnpm prune --prod

and Package.json

 "docker:build": "bash ./scripts/docker.sh build",

What does this PR do?

Change the package.json to run the correct script.
&& pnpm build-docker \
Renaming the docker:build script in your package.json to build-docker to match the command in the Dockerfile.

What kind of change is this?

Documentation changes needed?

Testing

Run this command to build docker image

docker buildx build --platform=linux/amd64 -t eliza:test .

Where should a reviewer start?

Detailed testing steps

@odilitime odilitime changed the base branch from main to develop December 28, 2024 09:17
@odilitime odilitime changed the title Update package.json with build-docker command fix: Update package.json with build-docker command Dec 28, 2024
@vanshika-srivastava vanshika-srivastava changed the title fix: Update package.json with build-docker command Update package.json with build-docker command to match the dockerfile command Dec 28, 2024
@vanshika-srivastava vanshika-srivastava changed the title Update package.json with build-docker command to match the dockerfile command Fix: Update package.json with build-docker command to match the dockerfile command Dec 28, 2024
@shakkernerd shakkernerd merged commit 438d736 into elizaOS:develop Dec 28, 2024
3 checks passed
@vanshika-srivastava
Copy link
Contributor Author

Hey @shakkernerd I just the new version of package.json includes the build-docker command. This fixes the issue with dockerfile

1to3for5vi7ate9x pushed a commit to 1to3for5vi7ate9x/eliza that referenced this pull request Jan 26, 2025
Fix: Update package.json with build-docker command to match the dockerfile command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants