-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make search feature in twitter client works #1433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this please address the comments then good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much more elegant, banging my head, why didn't I think of that
fix: Make search feature in twitter client works
Relates to:
This PR has written without issue ticket
Risks
Low
Background
What does this PR do?
Modified the enableSearch feature of the twitter client to make it work.
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
We wanted the AI Agent to be exposed to random posts to learn and to respond to members of the community, and we found the TWITTER_SEARCH_ENABLE environment variable while looking for a way to do so. However, we confirmed that it was missing during the development process and that the environment variable was not working properly, so we modified it to be as identical to other toggle functions as possible.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Just run agent with twitter client with TWITTER_SEARCH_ENABLE environment variable
Detailed testing steps
None, not much details needed.
Discord username
blairlee_dev