Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make search feature in twitter client works #1433

Merged
merged 13 commits into from
Dec 25, 2024
Merged

Conversation

nulLeeKH
Copy link
Contributor

Relates to:

This PR has written without issue ticket

Risks

Low

Background

What does this PR do?

Modified the enableSearch feature of the twitter client to make it work.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

We wanted the AI Agent to be exposed to random posts to learn and to respond to members of the community, and we found the TWITTER_SEARCH_ENABLE environment variable while looking for a way to do so. However, we confirmed that it was missing during the development process and that the environment variable was not working properly, so we modified it to be as identical to other toggle functions as possible.

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Just run agent with twitter client with TWITTER_SEARCH_ENABLE environment variable

Detailed testing steps

None, not much details needed.

Discord username

blairlee_dev

@nulLeeKH nulLeeKH changed the title Make enablesearch work Make search feature in twitter client works Dec 24, 2024
@nulLeeKH nulLeeKH changed the base branch from main to develop December 24, 2024 13:54
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this please address the comments then good to go :)

agent/src/index.ts Outdated Show resolved Hide resolved
packages/client-twitter/src/index.ts Outdated Show resolved Hide resolved
@nulLeeKH nulLeeKH requested a review from monilpat December 24, 2024 18:26
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing comments :)

@odilitime odilitime changed the title Make search feature in twitter client works fix: Make search feature in twitter client works Dec 25, 2024
Copy link
Collaborator

@odilitime odilitime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more elegant, banging my head, why didn't I think of that

@twilwa twilwa merged commit 49aa5d9 into elizaOS:develop Dec 25, 2024
3 checks passed
1to3for5vi7ate9x pushed a commit to 1to3for5vi7ate9x/eliza that referenced this pull request Jan 26, 2025
fix: Make search feature in twitter client works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants