-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Keeps README translations synchronized #1432
chore: Keeps README translations synchronized #1432
Conversation
…multiple languages on push events
…ath to streamline workflow execution
…tions.yml to use quotes for consistency and prevent potential parsing issues
… translation workflow to follow proper YAML structure
…o incorporate latest improvements and fixes
…or improved functionality and bug fixes
…ters in README content to ensure proper formatting during translation process
… characters to ensure correct file creation
…ADME translation process and improve artifact handling - Remove unnecessary steps for reading and escaping README content. - Update the action version for translation to v1.2.0 for better performance. - Use content_path to directly reference README.md for translation. - Add step to upload each translated file as an artifact. - Introduce a new commit step to handle all translated README files at once.
…or improved functionality and bug fixes
Is there a way for us to test that this works as expected? Bit worried about it missing up existing documentation? I suggest trying to do use the following to test it locally: • Description: “act” is a command-line utility written in Go that lets you run your GitHub Actions workflows locally. Great for quickly iterating on a workflow without having to push to a branch repeatedly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test that this works thank you :)
Thanks for doing this btw HUGE much appreciated :) |
Hey @monilpat , I already tried many times to test it locally with act before but I've some node js runtime error that don't appear in real github actions environnement or just when running the action plugin locally with my node js: [Generate Readme Translations/translation-5 ] ☁ git clone 'https://github.com/actions/checkout' # ref=v4
| /run/act/actions/[email protected]/dist/index.js:53292
| class EventSourceParserStream extends TransformStream {
| ^
|
| ReferenceError: TransformStream is not defined
| at Object.9201 (/run/act/actions/[email protected]/dist/index.js:53292:39)
| at __nccwpck_require__ (/run/act/actions/[email protected]/dist/index.js:53384:43)
| at Object.1746 (/run/act/actions/[email protected]/dist/index.js:10618:21)
| at __nccwpck_require__ (/run/act/actions/[email protected]/dist/index.js:53384:43)
| at Object.3201 (/run/act/actions/[email protected]/dist/index.js:3484:30)
| at __nccwpck_require__ (/run/act/actions/[email protected]/dist/index.js:53384:43)
| at Object.4279 (/run/act/actions/[email protected]/dist/index.js:184:21)
| at __nccwpck_require__ (/run/act/actions/[email protected]/dist/index.js:53384:43)
| at Object.1536 (/run/act/actions/[email protected]/dist/index.js:22:36)
| at __nccwpck_require__ (/run/act/actions/[email protected]/dist/index.js:53384:43) so here's the link of my working test on github: merry xmas :) |
Amazing thanks for sharing the successful working test on github much appreciated Merry Xmas :))) |
Let’s go ! have a good holiday sir :) |
Relates to:
chore: Keeps README translations synchronized
Risks
Medium. Changes to the main README file could affect all translated versions, and any errors in the translation script could propagate incorrect information across all language files.
Background
What does this PR do?
Implements a script that uses GPT-o4 to automatically update and translate all the README files whenever the English README.md file changes. Integrates with GitHub CI for automation.
What kind of change is this?
Documentation changes needed?
Not applicable.
Testing
Where should a reviewer start?
Start with the new script implementation and its integration with GitHub Actions for CI.
Detailed testing steps
Screenshots
Before
Not applicable.
After
Not applicable.
Deploy Notes
No special deployment instructions needed.
Database changes
None.
Deployment instructions
Before the workflow can run, you need to set up the following secrets in your GitHub repository:
GH_TOKEN
repo
permissionsOPENAI_API_KEY